Differential D2890

Move Tool fix.
ClosedPublic
Actions

Authored by tantsevov on Sep 29 2016, 9:08 PM.

Details

Reviewers
dkazakov
woltherav
rempt
Commits
R37:9b1fda27517d: Move Tool fix.
Summary

Fix wrong Move Tool work in Instant Preview Mode.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tantsevov updated this revision to Diff 6997.Sep 29 2016, 9:08 PM
tantsevov retitled this revision from to Move Tool fix..
tantsevov updated this object.
tantsevov edited the test plan for this revision. (Show Details)
tantsevov added reviewers: dkazakov, rempt, woltherav.
tantsevov set the repository for this revision to R37 Krita.
tantsevov added a project: Krita.
tantsevov added a subscriber: Krita.
dkazakov accepted this revision.Oct 1 2016, 7:54 PM
dkazakov edited edge metadata.

The patch looks and works fine!

The only drawback I managed to notice is that two variables m_startPosition and m_accumulatedOffset track the same value with a constant offset. Please remove one of them to simplify code and push! :)

This revision is now accepted and ready to land.Oct 1 2016, 7:54 PM
rempt edited edge metadata.Oct 7 2016, 9:19 AM

Was this pushed already?

tantsevov added a comment.Oct 7 2016, 4:47 PM
In D2890#55219, @rempt wrote:

Was this pushed already?

Sorry, I have problems with ssh

tantsevov added a comment.Oct 7 2016, 4:50 PM
In D2890#55219, @rempt wrote:

Was this pushed already?

Btw, last patch didn't solve problem with Instant Preview Mode

Closed by commit R37:9b1fda27517d: Move Tool fix. (authored by tantsevov). · Explain WhyOct 12 2016, 12:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7342

View Options

plugins/tools/basictools/kis_tool_move.h

Loading...
View Options

plugins/tools/basictools/kis_tool_move.cc

Loading...