Differential D28890

Make UI tests use a separate userdb
ClosedPublic
Actions

Authored by TallFurryMan on Apr 16 2020, 4:28 PM.

Details

Reviewers

mutlaqja

Group Reviewers

KStars

Commits

R321:e7796bf9cec9: Make UI tests use a separate userdb

Summary

This differential makes UI tests independent on the local user settings by using the Qt Test Mode user. Basically it:

Uses test mode to make sure unitary userdb tests use a blank user db.
Uses test mode to make sure UI tests start from scratch, as the user folder is completely removed before testing.
Provides 'kstarsui.rc' explicitely when initializing KStars, so that (at last!) toolbars and menus are visible.

Now anyone can safely run UI tests without the risk that one's carefully tuned Ekos configuration is lost.

This differential should also fix builds made with no INDI dependency installed.

This differential also reworks the kstars_ui_tests header to (briefly) explain how to create UI tests, and some of the reasons they are written as they are.

Test Plan

Execute kstars_ui_tests.

Diff Detail

Repository

R321 KStars

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

TallFurryMan created this revision.Apr 16 2020, 4:28 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 16 2020, 4:28 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

TallFurryMan requested review of this revision.Apr 16 2020, 4:28 PM

Harbormaster completed remote builds in B25328: Diff 80293.Apr 16 2020, 4:28 PM

TallFurryMan edited the summary of this revision. (Show Details)Apr 16 2020, 4:37 PM

TallFurryMan mentioned this in D28292: Refactoring the Focus module..Apr 16 2020, 4:41 PM

The Focus test is still quite long because there is currently no way to determine the star detection is finished.
And actually KStars sometimes crashes when a new capture is taken while the detection is still in progress. Another test to be built!

Merge branch 'master' into improve__userdb_tests

Harbormaster completed remote builds in B25333: Diff 80302.Apr 16 2020, 5:15 PM

mutlaqja accepted this revision.Apr 17 2020, 4:40 PM

This revision is now accepted and ready to land.Apr 17 2020, 4:40 PM

Closed by commit R321:e7796bf9cec9: Make UI tests use a separate userdb (authored by TallFurryMan, committed by mutlaqja). · Explain WhyApr 17 2020, 4:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		Tests/auxiliary/testksuserdb.h (2 lines)
M		Tests/auxiliary/testksuserdb.cpp (31 lines)
M		Tests/kstars_ui/CMakeLists.txt (2 lines)
P		Tests/kstars_ui/kstars_ui_tests.h (102 lines) Copied to Tests/kstars_ui/test_kstars_startup.h
M		Tests/kstars_ui/kstars_ui_tests.cpp (140 lines)
M		Tests/kstars_ui/test_ekos.h (14 lines)
M		Tests/kstars_ui/test_ekos.cpp (16 lines)
M		Tests/kstars_ui/test_ekos_focus.h (9 lines)
M		Tests/kstars_ui/test_ekos_focus.cpp (15 lines)
M		Tests/kstars_ui/test_ekos_simulator.h (14 lines)
M		Tests/kstars_ui/test_ekos_simulator.cpp (15 lines)
A	M	Tests/kstars_ui/test_ekos_wizard.h (20 lines)
A	M	Tests/kstars_ui/test_ekos_wizard.cpp (92 lines)
P		Tests/kstars_ui/test_kstars_startup.h (31 lines) Copied from Tests/kstars_ui/kstars_ui_tests.h
A	M	Tests/kstars_ui/test_kstars_startup.cpp (151 lines)
M		kstars/kstarsinit.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	80293	56051aa		Apr 16 2020, 4:28 PM	★	★
Diff 2	80302	c859850	- Merge branch 'master' into improve__userdb_tests	Apr 16 2020, 5:15 PM	★	★
Diff 3	80410	515efd4	R321:e7796bf9cec91cd9ef08b6eb311a29b7bdcc159d	Apr 17 2020, 4:40 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
71ce2324971a	83107fbeed8a	172bf8257f06 c859850b146d	Eric Dejouhanet	Merge branch 'master' into improve__userdb_tests	Apr 16 2020, 5:14 PM
172bf8257f06	aca13de950c9	52ab5b6a92ee	Eric Dejouhanet	Make UI tests use a separate userdb (Show More…)	Apr 14 2020, 7:19 AM
52ab5b6a92ee	2c667dfe896c	d0f8724477ff	Eric Dejouhanet	Use test mode to make sure UI tests use a blank user db.	Apr 10 2020, 8:52 PM
d0f8724477ff	ef1a3a80b9c9	56051aa47ca0	Eric Dejouhanet	Use test mode to safely initialize user database.	Apr 10 2020, 8:47 PM

Make UI tests use a separate userdbClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 80410

Tests/auxiliary/testksuserdb.h

Tests/auxiliary/testksuserdb.cpp

Tests/kstars_ui/CMakeLists.txt

Tests/kstars_ui/kstars_ui_tests.h

Tests/kstars_ui/kstars_ui_tests.cpp

Tests/kstars_ui/test_ekos.h

Tests/kstars_ui/test_ekos.cpp

Tests/kstars_ui/test_ekos_focus.h

Tests/kstars_ui/test_ekos_focus.cpp

Tests/kstars_ui/test_ekos_simulator.h

Tests/kstars_ui/test_ekos_simulator.cpp

Tests/kstars_ui/test_ekos_wizard.h

Tests/kstars_ui/test_ekos_wizard.cpp

Tests/kstars_ui/test_kstars_startup.h

Tests/kstars_ui/test_kstars_startup.cpp

kstars/kstarsinit.cpp

Make UI tests use a separate userdb
ClosedPublic
Actions

Revision Contents
Changeset List