Added tests for the Focus module.
Changes PlannedPublic

Authored by TallFurryMan on Wed, Mar 25, 11:08 PM.

Details

Reviewers
None
Group Reviewers
KStars
Summary

This is a WIP on tests for the Focus module.
We see that:

  • There is no way to determine when the star detection procedure is done. The capture button should re-enable when everything is finished.
  • The CCD Simulator needs improvement for some detection mechanisms to work properly.
  • It is difficult to create fixtures with deterministic verifications, although better controlling the simulation time should help.
  • Syncing the mount to object coordinates is a good idea to speed up tests.
  • When not tracking, the CCD Simulator doesn't render trails, it could be a nice improvement.
  • Because kstars_ui_tests is becoming larger, it needs to be divided into multiple smaller tests for efficiency.
  • QTest, because failing a test means returning from the test function, is macro hell.
  • QComboBox is difficult to control programmatically because of its internal signal management.
Test Plan

Run kstars_ui_tests.

Diff Detail

Repository
R321 KStars
Branch
improve__concurrent_star_detector (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24239
Build 24257: arc lint + arc unit
TallFurryMan created this revision.Wed, Mar 25, 11:08 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptWed, Mar 25, 11:08 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
TallFurryMan requested review of this revision.Wed, Mar 25, 11:08 PM
TallFurryMan planned changes to this revision.Wed, Mar 25, 11:08 PM

Spotted KTRY_EKOS_CLICK that I forgot to refactor in the same vein as KTRY_FOCUS_CLICK.