Differential D2886

Fixing loading for the wallpaper thumbnails in the activity switcher
ClosedPublic
Actions

Authored by ivan on Sep 29 2016, 11:42 AM.

Details

Reviewers
davidedmundson
mart
Group Reviewers
Plasma
Commits
R119:f49216b72110: Fixing loading for the wallpaper thumbnails in the activity switcher
Summary
  • Using shared config object for retrieving the wallpaper
  • Adding preference for taking the wallpaper from the containment with the lowest screen id

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ivan updated this revision to Diff 6988.Sep 29 2016, 11:42 AM
ivan retitled this revision from to Fixing loading for the wallpaper thumbnails in the activity switcher.
ivan updated this object.
ivan edited the test plan for this revision. (Show Details)
ivan added reviewers: Plasma, davidedmundson, mart.
ivan added a project: Plasma.
ivan added a subscriber: plasma-devel.
ivan added a comment.Sep 29 2016, 11:44 AM

Note: It still does reparseConfiguration() - it does not work as expected otherwise.

mart edited edge metadata.Sep 29 2016, 11:54 AM
In D2886#53635, @ivan wrote:

Note: It still does reparseConfiguration() - it does not work as expected otherwise.

I'm in favor of the patch in general..
If the file was changed by another process or somewhere else in the same not by a ksharedconfig i think that is expected ksharedconfig does not actually notice.

or.. could be possible is actually a ksharedconfig bug? maybe this could be autotestable in kconfig framework?

ivan updated this revision to Diff 6989.Sep 29 2016, 12:02 PM
ivan edited edge metadata.

With some debugging output

davidedmundson accepted this revision.Sep 29 2016, 12:08 PM
davidedmundson edited edge metadata.
This revision is now accepted and ready to land.Sep 29 2016, 12:08 PM
mart accepted this revision.Sep 29 2016, 12:15 PM
mart edited edge metadata.
ivan updated this revision to Diff 6990.Sep 29 2016, 1:42 PM
ivan edited edge metadata.

Removed debugging output before landing

Closed by commit R119:f49216b72110: Fixing loading for the wallpaper thumbnails in the activity switcher (authored by ivan). · Explain WhySep 29 2016, 1:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6991

View Options

imports/activitymanager/sortedactivitiesmodel.cpp

Loading...