Differential D28776

FstabDevice: Avoid recurrent construction of emblems QStringList
Needs ReviewPublic
Actions

Authored by bruns on Apr 12 2020, 6:13 PM.

Details

Reviewers
apol
Group Reviewers
Frameworks
Summary

emblems can return exactly two different values. Construct the two
possible values statically, so these can be shared by all FstabDevice
instances.

Test Plan

correct emblems are still shown

Diff Detail

Repository
R245 Solid
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25151
Build 25169: arc lint + arc unit
bruns created this revision.Apr 12 2020, 6:13 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 12 2020, 6:13 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 12 2020, 6:13 PM
bruns added a dependent revision: D28777: FstabDevice: Reevaluate emblems only when state changes.
apol accepted this revision.Apr 12 2020, 8:48 PM
This revision is now accepted and ready to land.Apr 12 2020, 8:48 PM
apol requested changes to this revision.Apr 12 2020, 8:53 PM

Address the scope of the statics as kai mentioned in D28778.
Or use Q_GLOBAL_STATIC.

This revision now requires changes to proceed.Apr 12 2020, 8:53 PM
bruns updated this revision to Diff 79989.Apr 13 2020, 10:13 AM

put statics in namespace

Revision Contents
Changeset List

Diff 79989

View Options

src/solid/devices/backends/fstab/fstabdevice.cpp

Loading...