It's not done anywhere and breaks rendering the ComboBox on high dpi.
Details
Details
- Reviewers
davidre hpereiradacosta davidedmundson - Group Reviewers
Plasma - Commits
- R31:0eaf762705d8: Drop QWindow and explicit devicePixelRatio usage for ComboBox
Would still like to know why this originally passed the window to it
Before
After
Diff Detail
Diff Detail
- Repository
- R31 Breeze
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
kstyle/breezestyle.cpp | ||
---|---|---|
4474 ↗ | (On Diff #79773) | QPixmap Helper::coloredIcon(const QIcon& icon, const QPalette& palette, const QSize &size, QIcon::Mode mode, QIcon::State state) ... const QPixmap pixmap = icon.pixmap(size, mode, state); this takes a logical size, so this is indeed wrong. |