This differential is a hotfix for the recent work in the Focus module.
One additional class, FITSSkyObject, was extracted and put in its own source files.
The JMIndex parameter of the Centroid detection was not provided to the source extraction procedure.
The Star Profile Viewer missed a few consts in its management of FITS data buffer, which caused some Jenkins builds to fail on SUSE and FreeBSD.
Details
Details
- Reviewers
mutlaqja - Group Reviewers
KStars - Commits
- R321:56051aa47ca0: Hotfixes for the Focus module
Run kstars_ui_tests
Diff Detail
Diff Detail
- Repository
- R321 KStars
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
A few things I wanted to add but will delay:
- UI does not reflect the use of SEP and Centroid for initial detection, nor for full-field analysis.
- Due to the first point, the tests are not properly verifying the Threshold and Gradient algorithms because the full-field analysis option is set!
- UI does a weird toggle on the capture button when preparing the screen, and re-enables said button *before* the star extraction completes (that code block is tricky to refactor).
- Due to the first point, the tests need to wait an arbitrary duration to verify the detection results.