Differential D28681

[svn] Fixed items status inside unversioned directory.
ClosedPublic
Actions

Authored by nikolaik on Apr 8 2020, 4:34 PM.

Details

Reviewers
meven
elvisangelaccio
Group Reviewers
Dolphin
Commits
R449:f691f024aab9: [svn] Fixed items status inside unversioned directory.
R449:4ea1d416415a: [svn] Fixed items status inside unversioned directory.
Summary

Added special checks for items inside unversioned dirs.
Previously those items was indicated as normal revision with a capability to launch SVN commands on it (SVN Delete, for example). Those commands ends up with an error.

Unversioned item is a special case because in any other cases 'svn status' will mark every file or dir as added, removed, conflicted and so on.

Test Plan

Inside a repo create dir with a following structure:

  1. Check any SVN actions available only for "dir", selecting other dirs and files causes no actions available.
  2. Check items status showing correct.
  3. Do 'SVN Add' for dir, 'SVN Revert' for dir2.
  4. Check dir (with dir1.txt, file1.txt) and dir/dir1 (with file2.txt) and dir/dir1/dir2 has SVN Actions while dir/dir1/dir2/dir3 don't.
  5. Check items status showing correct.

Diff Detail

Repository
R449 Plugins for Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nikolaik requested review of this revision.Apr 8 2020, 4:34 PM
nikolaik created this revision.
nikolaik edited the test plan for this revision. (Show Details)Apr 8 2020, 4:36 PM
nikolaik edited the test plan for this revision. (Show Details)Apr 9 2020, 10:36 AM
nikolaik edited the test plan for this revision. (Show Details)
meven added a comment.Apr 11 2020, 7:07 AM

Small typo, looks good

svn/fileviewsvnplugin.h
102

Replace either by otherwise

nikolaik updated this revision to Diff 79876.Apr 11 2020, 4:52 PM

Update in response to review comments.

nikolaik marked an inline comment as done.Apr 11 2020, 4:52 PM
meven set the repository for this revision to R449 Plugins for Dolphin.Apr 11 2020, 4:56 PM
meven added a reviewer: Dolphin.
elvisangelaccio requested changes to this revision.Apr 12 2020, 10:09 AM

Looks good otherwise.

svn/fileviewsvnplugin.cpp
676

Please move this declaration inside the for

679

Code style: remove space after ( and before )

This revision now requires changes to proceed.Apr 12 2020, 10:09 AM
nikolaik updated this revision to Diff 79919.Apr 12 2020, 11:28 AM

Update in response to comments.

nikolaik marked 2 inline comments as done.Apr 12 2020, 11:29 AM
nikolaik set the repository for this revision to R449 Plugins for Dolphin.Apr 12 2020, 11:31 AM
meven requested changes to this revision.Apr 12 2020, 11:47 AM

Nearly there, another small thing

svn/fileviewsvnplugin.cpp
264

items is already const, not need for qAsConst here

This revision now requires changes to proceed.Apr 12 2020, 11:47 AM
nikolaik updated this revision to Diff 79921.Apr 12 2020, 11:54 AM

Thanks for comments!
Update done.

nikolaik marked an inline comment as done.Apr 12 2020, 11:54 AM
meven accepted this revision as: meven.Apr 12 2020, 12:01 PM
elvisangelaccio accepted this revision.Apr 12 2020, 5:13 PM

Please push to release/20.04.

This revision is now accepted and ready to land.Apr 12 2020, 5:13 PM
nikolaik set the repository for this revision to R449 Plugins for Dolphin.Apr 12 2020, 6:52 PM
Closed by commit R449:f691f024aab9: [svn] Fixed items status inside unversioned directory. (authored by nikolaik). · Explain WhyApr 12 2020, 7:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msvn/fileviewsvnplugin.h (7 lines)
Msvn/fileviewsvnplugin.cpp (27 lines)

Diff 79956

View Options

svn/fileviewsvnplugin.h

Loading...
View Options

svn/fileviewsvnplugin.cpp

Loading...