drm: Improve QDebug of DrmOutput
ClosedPublic
Actions

Authored by apol on Apr 8 2020, 2:13 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

Instead of printing as QObject, provide actual information of the
instance.

drm: Don't leak planes

drm: properly access a scoped pointer

Test Plan

Running it locally

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: KWin. · View Herald TranscriptApr 8 2020, 2:13 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

apol requested review of this revision.Apr 8 2020, 2:13 PM

This revision is now accepted and ready to land.Apr 8 2020, 2:23 PM

This revision was automatically updated to reflect the committed changes.

Does this need QDebugStateSaver?

			Path	Packages
M			plugins/platforms/drm/drm_output.h (13 lines)
M			plugins/platforms/drm/drm_output.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	79644	a13ecf8		Apr 8 2020, 2:13 PM	★	★
Diff 2	79645	a13ecf8	R108:fa654bda59d16f46b0793d9d160ff70481528e9d	Apr 8 2020, 2:11 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
61dcb2f1740c	ce270e12fbd1	16fe8dbd88d8	Aleix Pol	drm: properly access a scoped pointer	Apr 8 2020, 2:12 PM
16fe8dbd88d8	6a482bbc07c7	fa654bda59d1	Aleix Pol	drm: Don't leak planes	Apr 8 2020, 2:12 PM
fa654bda59d1	d63bf46393de	a13ecf8d0e03	Aleix Pol	drm: Improve QDebug of DrmOutput (Show More…)	Apr 8 2020, 2:07 PM