Use the canonical location for the screenshot, and fix width/height to match its actual size.
Details
Details
- Reviewers
dvratil - Group Reviewers
KDE PIM - Commits
- R204:030b3113ede6: appstream: fix screenshot URL and size
appstreamcli validate src/data/org.kde.kaddressbook.appdata.xml
Diff Detail
Diff Detail
- Repository
- R204 KAddressBook
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 24897 Build 24915: arc lint + arc unit
Comment Actions
Can you please explicitly say what are the changes (and possibly why)? The reason is that saying "fix $file so that $tool gives no errors" is valid today, may be valid tomorrow, however there is the risk that will be useless in 1/2/5 years on. Tools come and go, and even the reporting they produce change over time.
IMHO something like:
appstream: fix screenshot URL and size Use the canonical location for the screenshot, and fix width/height to match its actual size.
would be way better.
(BTW the current URL works fine for me.)