Differential D28648

appstream: fix screenshot URL and size
ClosedPublic
Actions

Authored by ognarb on Apr 7 2020, 11:03 AM.

Details

Reviewers
dvratil
Group Reviewers
KDE PIM
Commits
R204:030b3113ede6: appstream: fix screenshot URL and size
Summary

Use the canonical location for the screenshot, and fix width/height to match its actual size.

Test Plan

appstreamcli validate src/data/org.kde.kaddressbook.appdata.xml

Diff Detail

Repository
R204 KAddressBook
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Apr 7 2020, 11:03 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 7 2020, 11:03 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
ognarb requested review of this revision.Apr 7 2020, 11:03 AM
pino added a subscriber: pino.Apr 7 2020, 11:32 AM

Can you please explicitly say what are the changes (and possibly why)? The reason is that saying "fix $file so that $tool gives no errors" is valid today, may be valid tomorrow, however there is the risk that will be useless in 1/2/5 years on. Tools come and go, and even the reporting they produce change over time.

IMHO something like:

appstream: fix screenshot URL and size

Use the canonical location for the screenshot, and fix width/height to match its actual size.

would be way better.

(BTW the current URL works fine for me.)

dvratil accepted this revision.Apr 9 2020, 11:12 AM
dvratil added a subscriber: dvratil.

Please adjust the commit message as pino suggested, otherwise it's OK.

This revision is now accepted and ready to land.Apr 9 2020, 11:12 AM
ognarb retitled this revision from Fix AppStream information to appstream: fix screenshot URL and size.Apr 9 2020, 1:03 PM
ognarb edited the summary of this revision. (Show Details)
Closed by commit R204:030b3113ede6: appstream: fix screenshot URL and size (authored by ognarb). · Explain WhyApr 9 2020, 1:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 79707

View Options

src/data/org.kde.kaddressbook.appdata.xml

Loading...