Details
- Reviewers
nienhueser rahn
Diff Detail
- Repository
- R34 Marble
- Lint
Lint Skipped - Unit
Unit Tests Skipped
From what I remember the problem goes like this: On Android, change some setting, then open the application list and swipe Marble Maps to the right to kill it. The settings were not saved, so not restored upon the next start.
From what I understand from the patch, it works around it by saving settings when you open the application list and Marble Maps becomes not active. This seems ok, especially for the suspended state. What worries me is to load settings when it becomes active. This seems unneeded to me, and also dangerous in case a state change event would not get caught for some reason. Can you check if the patch works as well if you only save settings in suspended and inactive state, but do not load them here?
Makes sense. I modified the patch so that it only saves settings in suspended and inactive states, but not load them during any state change, and verified that it still resolves the issue.
Pushed to master with commit https://commits.kde.org/marble/d00d4b8db4af30a6582b5df5dcc6f692cfb88d27