Differential D28598

KRun: fix assert when failing to start an application
ClosedPublic
Actions

Authored by dfaure on Apr 5 2020, 4:56 PM.

Details

Reviewers
ahmadsamir
Commits
R241:009e5327d9a8: KRun: fix assert when failing to start an application
R241:bfc09fe2ae16: KRun: fix assert when failing to start an application
Test Plan

'sudo chmod a-x /usr/bin/gwenview'
Try opening a picure file from e.g. dolphin, you get an error message as expected, clicking OK makes dolphin crash because m_pids is empty and we hit an assert in QVector

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24805
Build 24823: arc lint + arc unit
dfaure created this revision.Apr 5 2020, 4:56 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 5 2020, 4:56 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Apr 5 2020, 4:56 PM
ahmadsamir accepted this revision.Apr 5 2020, 5:12 PM

Of course. That makes much more sense than the band aid fix in the (my) other diff.

This revision is now accepted and ready to land.Apr 5 2020, 5:12 PM
dfaure closed this revision.Apr 5 2020, 5:13 PM

Revision Contents
Changeset List

PathPackages
Msrc/widgets/krun.cpp (4 lines)

Diff 79420

View Options

src/widgets/krun.cpp

Loading...