[ApplicationLauncherJob] Guard against m_pids being empty
AbandonedPublic

Authored by ahmadsamir on Apr 5 2020, 1:21 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Test Plan
  • 'sudo chmod a-x /usr/bin/gwenview'
  • Try opening a picure file from e.g. dolphin, you get an error message as expected, clicking OK makes dolphin crash because m_pids is empty and we hit an assert in QVector

Diff Detail

Repository
R241 KIO
Branch
l-pids (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24798
Build 24816: arc lint + arc unit
ahmadsamir created this revision.Apr 5 2020, 1:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 5 2020, 1:21 PM
ahmadsamir requested review of this revision.Apr 5 2020, 1:21 PM
dfaure requested changes to this revision.Apr 5 2020, 4:57 PM

This, hmm, sounds wrong. Is the caller calling pid() even though the job finished with an error code? Ah, yes, indeed, in the case of KRun. Whoops.

Here's my suggested fix instead: D28598

This revision now requires changes to proceed.Apr 5 2020, 4:57 PM
ahmadsamir abandoned this revision.Apr 5 2020, 5:11 PM