Differential D28550

Optimize Firefox bookmark import query and fix to include folders
Needs ReviewPublic
Actions

Authored by abogical on Apr 4 2020, 6:15 AM.

Details

Reviewers
None
Group Reviewers
Falkon
Summary

BUG: 393254

Test Plan

Import Firefox bookmarks that has folders.
Expect imported bookmarks to have folders with the correct children in order.

Diff Detail

Repository
R875 Falkon
Branch
firefox-folder-bookmarks
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24974
Build 24992: arc lint + arc unit
abogical created this revision.Apr 4 2020, 6:15 AM
Restricted Application added a project: Falkon. · View Herald TranscriptApr 4 2020, 6:15 AM
Restricted Application added a subscriber: falkon. · View Herald Transcript
abogical requested review of this revision.Apr 4 2020, 6:15 AM
abogical edited the test plan for this revision. (Show Details)Apr 4 2020, 6:16 AM
abogical updated this revision to Diff 79260.Apr 4 2020, 6:18 AM

Comment grammar correction

abogical added subscribers: SGOrava, drosca, dfaure.Apr 7 2020, 9:50 PM

@drosca @dfaure @SGOrava
Do I need to add subscribers other than falkon? I have 3 other differentials that needs review but no response is made for some time, unless I mention by name.

abogical updated this revision to Diff 79682.Apr 9 2020, 3:07 AM

Improve query filter

dfaure added a comment.Apr 11 2020, 8:39 AM

No idea, I'm not a Falkon developer.

I simply stumbled upon the other diff by chance in phabricator.
I can comment on QUrl and range-for usage but I have no idea about the code in this patch.

Revision Contents
Changeset List

Diff 79682

View Options

src/lib/bookmarks/bookmarksimport/firefoximporter.h

Loading...
View Options

src/lib/bookmarks/bookmarksimport/firefoximporter.cpp

Loading...