Differential D28540

Fix layout in DownloadItemsSheet
ClosedPublic
Actions

Authored by leinir on Apr 3 2020, 2:46 PM.

Details

Reviewers
bugseforuns
mart
ngraham
Group Reviewers
Frameworks
Plasma
KNewStuff
Commits
R304:449d056a2d77: Fix layout in DownloadItemsSheet
Summary

The previous code was primarily there to work around misfeatures of OverlaySheet which no longer exist. Consequently, we don't have to leave in the hacks. Nice.

This further builds on the new OverlaySheet work done by Marco in https://commits.kde.org/kirigami/6f3800979f1387955ebd9c12aac031a9704853ae - resulting in the whole thing working much better, and with less client code. Nice.

BUG:419535

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Apr 3 2020, 2:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 3 2020, 2:46 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
leinir requested review of this revision.Apr 3 2020, 2:46 PM
leinir edited the summary of this revision. (Show Details)Apr 3 2020, 2:47 PM
leinir added reviewers: Frameworks, bugseforuns, mart, Plasma, KNewStuff.
ngraham accepted this revision.Apr 3 2020, 3:49 PM
This revision is now accepted and ready to land.Apr 3 2020, 3:49 PM
Closed by commit R304:449d056a2d77: Fix layout in DownloadItemsSheet (authored by leinir). · Explain WhyApr 4 2020, 1:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 79290

View Options

src/qtquick/qml/DownloadItemsSheet.qml

Loading...