Differential D28522

[QtQuick dialog] Port to UrlBUtton and hide when there's no URL
ClosedPublic
Actions

Authored by ngraham on Apr 2 2020, 5:18 PM.

Details

Reviewers
leinir
apol
Group Reviewers
KNewStuff
VDG
Commits
R304:d63e8bf49ce5: [QtQuick dialog] Port to UrlBUtton and hide when there's no URL
Summary

Port from linkButton to UrlButton for links that open webpages, as this is what
UrlButton was specifically designed for. Also hide any link that doesn't actually go
anywhere because the URL isn't defined by the data source.

Test Plan

There's no longer a donation button that doesn't do anything when clicked, and the
homepage link shows a tooltip when hovered.

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Apr 2 2020, 5:18 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 2 2020, 5:18 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 2 2020, 5:18 PM
apol accepted this revision.Apr 2 2020, 5:29 PM
This revision is now accepted and ready to land.Apr 2 2020, 5:29 PM
Closed by commit R304:d63e8bf49ce5: [QtQuick dialog] Port to UrlBUtton and hide when there's no URL (authored by ngraham). · Explain WhyApr 2 2020, 5:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qtquick/qml/EntryDetails.qml (10 lines)

Diff 79161

View Options

src/qtquick/qml/EntryDetails.qml

Loading...