A notification is sent when something
goes wrong setting up screencasting.
Details
Diff Detail
- Repository
- R838 Flatpak Support: KDE Portal for XDG Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/screencaststream.cpp | ||
---|---|---|
374 | .arg is unnecessary and in various cases can cause i18n() errors; just do it inline: notification->setText(i18n("Error: %1", body)); Also for short strings like this, it's nice to add some context for translators. | |
384 | Are there more user-friendly and actionable strings we could for these error messages? I have no idea what this means specifically and would read it as "there was some gobbeldygook error." |
src/screencaststream.cpp | ||
---|---|---|
384 | While I agree, I haven't been able to see what's the right way to get a more specific error message. Other implementations are doing the same. I guess we can go with this and if we ever find a better way to get information, we include it. |
src/xdp_kde.notifyrc | ||
---|---|---|
3 ↗ | (On Diff #79237) | I don't know if the comments are used in the Notifications KCM, but even if not, I would use a different one, maybe something like: A portal implementation integrated into KDE Plasma desktop. Opinions? |
src/screencaststream.cpp | ||
---|---|---|
376 | Does it need to be specified if you have Urgency=Normal set in the notifyrc file? I believe if you don't specify it, it will use the default urgency, which will be taken from the notifyrc file. |