Differential D28499

[LauncherJobs] Emit description
ClosedPublic
Actions

Authored by broulik on Apr 2 2020, 8:28 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Frameworks
Commits
R241:692d9bc81f00: [LauncherJobs] Emit description
Summary

Provides for better error reporting.

Test Plan

Can't go in before tagging due to string freeze

I kinda think KNotificationJobUiDelegate should add a "Failed" of sorts to the title since it doesn't go through the regular kuiserver job tracking which does that in case of an error

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 2 2020, 8:28 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 2 2020, 8:28 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Apr 2 2020, 8:28 AM
broulik added a comment.Apr 3 2020, 7:56 AM

Given we don't add elippsis after any other KIO Job (e.g. "Copying") probably shouldn't do it here either?

broulik updated this revision to Diff 79700.Apr 9 2020, 12:36 PM
  • Drop ellipsis
ngraham added a subscriber: ngraham.Apr 9 2020, 3:59 PM

Seems sensible and sane to me. +1

davidedmundson accepted this revision.Apr 21 2020, 11:13 AM
This revision is now accepted and ready to land.Apr 21 2020, 11:13 AM
Closed by commit R241:692d9bc81f00: [LauncherJobs] Emit description (authored by broulik). · Explain WhyMay 4 2020, 9:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81849

View Options

src/gui/applicationlauncherjob.cpp

Loading...
View Options

src/gui/commandlauncherjob.cpp

Loading...