[libnotificationmanager] forward notifications to lockscreen greeter
AbandonedPublic
Actions

Authored by bshah on Mar 31 2020, 5:58 AM.

Details

Reviewers

Summary

This is alternative to previous revision which talks to ksldapp and then
ksldapp talks to the greeter over private wayland server interface.

Test Plan

alternative to D28427

Repository

R120 Plasma Workspace

Branch

bshah/greeter-notify

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24512
Build 24530: arc lint + arc unit

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

bshah requested review of this revision.Mar 31 2020, 5:58 AM

Seems pretty simple and sensible.

1 minor fixup needed.

libnotificationmanager/server_p.cpp
234	"This" will lack any context when someone is actually debugging this.
244	I assume you forgot to have an iface.Close(...) line somewhere here

This revision now requires changes to proceed.Mar 31 2020, 8:54 AM

libnotificationmanager/server_p.cpp
234	"This" debug statement should be removed :P
244	Yes, I haven't got full functionality working yet, this was more of RFC.

bshah marked 2 inline comments as done.Mar 31 2020, 11:10 AM

			Path	Packages
M			libnotificationmanager/CMakeLists.txt (2 lines)
M			libnotificationmanager/notification.h (2 lines)
M			libnotificationmanager/notification.cpp (8 lines)
M			libnotificationmanager/notification_p.h (1 line)
M			libnotificationmanager/server_p.cpp (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	78951	804782d		Mar 31 2020, 5:58 AM	★	★
Diff 2	78961	804782d	- fix comments by David	Mar 31 2020, 9:02 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
1472aeb32f11	f56b0b8caac7	a26fc53284bb	Bhushan Shah	minor changes (Show More…)	Mar 31 2020, 9:00 AM
a26fc53284bb	aec2d625da33	804782df2adf	Bhushan Shah	[libnotificationmanager] forward notifications to lockscreen greeter (Show More…)	Mar 30 2020, 10:14 AM