[libnotificationmanager] forward notifications to lockscreen
AbandonedPublic

Authored by bshah on Mar 30 2020, 10:17 AM.

Details

Reviewers
None
Summary

This is currently WIP, and doesn't fully work, requires patches on both
kscreenlocker and lockscreen theme.

Test Plan

tested that dbus call is done using qDebugs for now

Diff Detail

Repository
R120 Plasma Workspace
Branch
bshah/ksld-notify
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24461
Build 24479: arc lint + arc unit
bshah created this revision.Mar 30 2020, 10:17 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 30 2020, 10:17 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah requested review of this revision.Mar 30 2020, 10:17 AM

So notifications are only forwarded if x-kde-show-on-lockscreen is set? I wonder if opt-out (x-kde-dont-show-on-lockscreen) would be better with regard to third-party apps. From a privacy POV I think a global dont-show-notis-on-lockscreen thing would make more sense than a per-app thing

bshah updated this revision to Diff 78884.Mar 30 2020, 12:10 PM
  • adapt to changes in the kscreenlocker

So notifications are only forwarded if x-kde-show-on-lockscreen is set? I wonder if opt-out (x-kde-dont-show-on-lockscreen) would be better with regard to third-party apps. From a privacy POV I think a global dont-show-notis-on-lockscreen thing would make more sense than a per-app thing

+1 to using global and per-notification blacklists rather than a per-notification whitelist

bshah added a subscriber: broulik.Mar 31 2020, 9:06 AM

+1 to using global and per-notification blacklists rather than a per-notification whitelist

Plan is to change this in future, but for now to keep code simple I and @broulik agreed on this solution.

(Also I am closing this diff in favor of the D28454

bshah abandoned this revision.Mar 31 2020, 9:06 AM