[libnotificationmanager] forward notifications to lockscreen greeter
AbandonedPublic

Authored by bshah on Mar 31 2020, 5:58 AM.

Details

Reviewers
davidedmundson
Summary

This is alternative to previous revision which talks to ksldapp and then
ksldapp talks to the greeter over private wayland server interface.

Test Plan

alternative to D28427

Diff Detail

Repository
R120 Plasma Workspace
Branch
bshah/greeter-notify
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24512
Build 24530: arc lint + arc unit
bshah created this revision.Mar 31 2020, 5:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 31 2020, 5:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah requested review of this revision.Mar 31 2020, 5:58 AM
davidedmundson requested changes to this revision.Mar 31 2020, 8:54 AM
davidedmundson added a subscriber: davidedmundson.

Seems pretty simple and sensible.

1 minor fixup needed.

libnotificationmanager/server_p.cpp
234

"This" will lack any context when someone is actually debugging this.

244

I assume you forgot to have an

iface.Close(...)

line somewhere here

This revision now requires changes to proceed.Mar 31 2020, 8:54 AM
bshah updated this revision to Diff 78961.Mar 31 2020, 9:02 AM
bshah marked 2 inline comments as done.
  • fix comments by David
bshah added inline comments.Mar 31 2020, 9:03 AM
libnotificationmanager/server_p.cpp
234

"This" debug statement should be removed :P

244

Yes, I haven't got full functionality working yet, this was more of RFC.

bshah marked 2 inline comments as done.Mar 31 2020, 11:10 AM
bshah abandoned this revision.Apr 22 2020, 2:48 PM