Differential D28384

[Extractor] Delay mimetype check, cleanup debug output
ClosedPublic
Actions

Authored by bruns on Mar 28 2020, 5:41 PM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
Commits
R293:6e0dd3e35389: [Extractor] Delay mimetype check, cleanup debug output
Summary

In case a file is skipped by a name filter there is no need to determine
the mimetype (which is costly, as a content based mimetype is used here).

Avoid multiple debug messages per file, only issue "Indexing ..." in
case the file is not skipped. All "Skipping ..." paths have a distinct.
debug/warning message.

Diff Detail

Repository
R293 Baloo
Branch
submit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24380
Build 24398: arc lint + arc unit
bruns created this revision.Mar 28 2020, 5:41 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 28 2020, 5:41 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Mar 28 2020, 5:41 PM
ngraham accepted this revision.Mar 30 2020, 12:05 AM

Good catch!

This revision is now accepted and ready to land.Mar 30 2020, 12:05 AM
Closed by commit R293:6e0dd3e35389: [Extractor] Delay mimetype check, cleanup debug output (authored by bruns). · Explain WhyMar 30 2020, 8:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/file/extractor/app.cpp (6 lines)

Diff 78745

View Options

src/file/extractor/app.cpp

Loading...