Differential D28163

Add input-dialpad and call-voicemail
ClosedPublic
Actions

Authored by ndavis on Mar 20 2020, 4:27 PM.

Details

Reviewers
None
Group Reviewers
VDG
Commits
R266:214dcc72f020: Add input-dialpad and call-voicemail
Summary

Requested by @bshah for Plasma Mobile

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Mar 20 2020, 4:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 20 2020, 4:27 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Mar 20 2020, 4:27 PM
ndavis edited the test plan for this revision. (Show Details)Mar 20 2020, 4:30 PM
ngraham added a subscriber: ngraham.Mar 20 2020, 4:53 PM

The 22px dialpad icon looks a bit stretched horizontally to me to my eyes. The others look fine.

ndavis added a comment.Mar 20 2020, 4:56 PM
In D28163#631343, @ngraham wrote:

The 22px dialpad icon looks a bit stretched horizontally to me to my eyes. The others look fine.

I agree, but it's really hard to get the proportions right and have it respect the usual margins. Do you think it would be OK to break the rules on margins here?

ngraham added a comment.Mar 20 2020, 4:57 PM

I thought the margins were maximums. Making the icon skinnier seems fine to me.

ndavis added a comment.Mar 20 2020, 5:00 PM
In D28163#631346, @ngraham wrote:

I thought the margins were maximums. Making the icon skinnier seems fine to me.

they are maximums. those guides are at the canvas size. At the correct proportion, it's 22px tall. If I try to shrink the size of the squares, then I get ridiculous spacing or they make the icon off center.

ngraham added a comment.Mar 20 2020, 9:23 PM

Maybe we could keep the dots 2x2 for the 22px version?

bshah added a comment.Mar 20 2020, 11:48 PM

Hmm yeah I am also not a fan of the stretched out dialpad icon

ndavis added a comment.Mar 21 2020, 2:25 AM
In D28163#631474, @ngraham wrote:

Maybe we could keep the dots 2x2 for the 22px version?

You can't get even spacing unless you make it way smaller than a normal 22px icon.

ngraham added a comment.Mar 21 2020, 4:05 AM

Well, I'm out of ideas

ndavis updated this revision to Diff 78136.Mar 21 2020, 4:33 AM
  • Use evenly distributed and proportioned style for dialpad
ndavis edited the test plan for this revision. (Show Details)Mar 21 2020, 4:34 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 22 2020, 12:35 PM
Closed by commit R266:214dcc72f020: Add input-dialpad and call-voicemail (authored by ndavis). · Explain Why
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 12 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 78218