Differential D28158

[Cursor Theme KCM] Use standardized pointer and help cursor for preview
ClosedPublic
Actions

Authored by broulik on Mar 20 2020, 9:11 AM.

Details

Reviewers
davidedmundson
ngraham
Group Reviewers
Plasma
Commits
R119:10c1a42b2cbf: [Cursor Theme KCM] Use standardized pointer and help cursor for preview
Summary

According to XDG cursor spec [1] the names are "pointer" and "help" for the pointing hand and what's this cursors.

[1] https://www.freedesktop.org/wiki/Specifications/cursor-spec/

Test Plan

5.18?

  • I now get proper previews for those

Before:


After:

(that el capitan theme is a random theme I got from the store and lacks a bunch of icons and sizes, so I'm not surprised it looks quite broken)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 20 2020, 9:11 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 20 2020, 9:11 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 20 2020, 9:11 AM
davidedmundson accepted this revision.Mar 20 2020, 9:31 AM
This revision is now accepted and ready to land.Mar 20 2020, 9:31 AM
ngraham accepted this revision.Mar 20 2020, 2:19 PM
ngraham added a subscriber: ngraham.

stable branch

Closed by commit R119:10c1a42b2cbf: [Cursor Theme KCM] Use standardized pointer and help cursor for preview (authored by broulik). · Explain WhyMar 20 2020, 2:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 78073

View Options

kcms/cursortheme/xcursor/previewwidget.cpp

Loading...