Use libcanberra as primary means of previewing the sound
ClosedPublic

Authored by broulik on Mar 18 2020, 11:21 AM.

Details

Reviewers
sitter
Group Reviewers
Frameworks
Summary

So it matches what KNotification is doing, especially since Phonon allows playing all sorts of files, which would then end up not being played when the notification is emitted.

Test Plan
  • Playback via canberra works, doesn't crash on teardown, multiple different sounds and playing the same sound repeatedly works
  • Playback via Phonon still works when canberra isn't found

Diff Detail

Repository
R305 KNotifyConfig
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 18 2020, 11:21 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 18 2020, 11:21 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Mar 18 2020, 11:21 AM
sitter accepted this revision.Mar 18 2020, 11:45 AM

Your if<space>( style is now inconsistent with the endif(.
Code LGTM

This revision is now accepted and ready to land.Mar 18 2020, 11:45 AM