Differential D28080

Remove hack for QButtonBox
ClosedPublic
Actions

Authored by davidre on Mar 16 2020, 5:29 PM.

Details

Reviewers
ervin
ngraham
Group Reviewers
Spectacle
Commits
R166:79a539b025c0: Merge branch 'release/20.04'
R166:1e3b21c76f59: Remove hack for QButtonBox
Summary

Use a flat groupbox which works out of the box

Test Plan

works

Diff Detail

Repository
R166 Spectacle
Branch
removehack (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23774
Build 23792: arc lint + arc unit
davidre created this revision.Mar 16 2020, 5:29 PM
Restricted Application added a project: Spectacle. · View Herald TranscriptMar 16 2020, 5:29 PM
davidre requested review of this revision.Mar 16 2020, 5:29 PM
davidre added a comment.Mar 16 2020, 5:31 PM

Any advice if master only or also 20.04?

ngraham accepted this revision.Mar 16 2020, 5:38 PM
ngraham added a subscriber: ngraham.

20.04 is fine IMO.

This revision is now accepted and ready to land.Mar 16 2020, 5:38 PM
davidre updated this revision to Diff 77757.Mar 16 2020, 5:42 PM

Make xml nicer

Closed by commit R166:1e3b21c76f59: Remove hack for QButtonBox (authored by davidre). · Explain WhyMar 16 2020, 5:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 77757

View Options

src/Gui/SettingsDialog/GeneralOptions.ui

Loading...
View Options

src/Gui/SettingsDialog/GeneralOptionsPage.cpp

Loading...