Remove hack for QButtonBox
ClosedPublic
Actions

Authored by davidre on Mar 16 2020, 5:29 PM.

Details

Reviewers

ervin
ngraham

Group Reviewers

Spectacle

Commits

Summary

Use a flat groupbox which works out of the box

Test Plan

works

Repository

R166 Spectacle

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidre requested review of this revision.Mar 16 2020, 5:29 PM

Any advice if master only or also 20.04?

20.04 is fine IMO.

This revision is now accepted and ready to land.Mar 16 2020, 5:38 PM

Make xml nicer

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/Gui/SettingsDialog/GeneralOptions.ui (102 lines)
M			src/Gui/SettingsDialog/GeneralOptionsPage.cpp (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	77755	c78b499		Mar 16 2020, 5:29 PM	★	★
Diff 2	77757	c78b499	Make xml nicer	Mar 16 2020, 5:42 PM	★	★
Diff 3	77758	1a5ba09	R166:1e3b21c76f5981bc80e7ffdff0ea1aa9009f26e0	Mar 16 2020, 5:48 PM	★	★