[Baloo KCM] Expose "Index hidden" config setting
ClosedPublic

Authored by bruns on Fri, Mar 13, 2:01 PM.

Details

Summary

Also inset both "Index file content" and "Index hidden" so it is more
obvious both are subordinate to the global "Enable indexing".

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Fri, Mar 13, 2:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Mar 13, 2:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bruns requested review of this revision.Fri, Mar 13, 2:01 PM
ngraham added inline comments.Sun, Mar 15, 12:51 AM
kcms/baloo/package/contents/ui/main.qml
59

Instead adding these new layouts, you could just set the following on each checkbox that needs to be indented:

Layout.leftMargin: !LayoutMirroring.enabled ? Kirigami.Units.largeSpacing : 0
Layout.rightMargin: LayoutMirroring.enabled ? Kirigami.Units.largeSpacing : 0

IMO that's a bit cleaner.

bruns added inline comments.Sun, Mar 15, 1:21 AM
kcms/baloo/package/contents/ui/main.qml
59

The effect would be different, as currently there already is some margin.

Also, this has to be repeated for each item, and I plan to add (at least) one more option.

ngraham accepted this revision.Sun, Mar 15, 4:55 AM

All right, let's go for it as-is.

This revision is now accepted and ready to land.Sun, Mar 15, 4:55 AM
This revision was automatically updated to reflect the committed changes.