Differential D28024

[Baloo KCM] Expose "Index hidden" config setting
ClosedPublic
Actions

Authored by bruns on Mar 13 2020, 2:01 PM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
VDG
Commits
R119:491ce0f1d78f: [Baloo KCM] Expose "Index hidden" config setting
Summary

Also inset both "Index file content" and "Index hidden" so it is more
obvious both are subordinate to the global "Enable indexing".

Diff Detail

Repository
R119 Plasma Desktop
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23658
Build 23676: arc lint + arc unit
bruns created this revision.Mar 13 2020, 2:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 13 2020, 2:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bruns requested review of this revision.Mar 13 2020, 2:01 PM
ngraham added inline comments.Mar 15 2020, 12:51 AM
kcms/baloo/package/contents/ui/main.qml
59

Instead adding these new layouts, you could just set the following on each checkbox that needs to be indented:

Layout.leftMargin: !LayoutMirroring.enabled ? Kirigami.Units.largeSpacing : 0
Layout.rightMargin: LayoutMirroring.enabled ? Kirigami.Units.largeSpacing : 0

IMO that's a bit cleaner.

bruns added inline comments.Mar 15 2020, 1:21 AM
kcms/baloo/package/contents/ui/main.qml
59

The effect would be different, as currently there already is some margin.

Also, this has to be repeated for each item, and I plan to add (at least) one more option.

ngraham accepted this revision.Mar 15 2020, 4:55 AM

All right, let's go for it as-is.

This revision is now accepted and ready to land.Mar 15 2020, 4:55 AM
Closed by commit R119:491ce0f1d78f: [Baloo KCM] Expose "Index hidden" config setting (authored by bruns). · Explain WhyMar 15 2020, 5:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 77558

View Options

kcms/baloo/package/contents/ui/main.qml

Loading...