Differential D27907

Fix a bug in the debayer offset code.
ClosedPublic
Actions

Authored by murveit on Mar 7 2020, 1:53 AM.

Details

Reviewers
mutlaqja
Commits
R321:8c53c246b7cd: Fix a bug in the debayer offset code.
Summary

When X-offset was given in the fits header, the code caused a read past the end of the buffer.
See https://indilib.org/forum/development/6565-bug-in-fitsdata-cpp/50506.html

Test Plan

fit bayer file with XBAYROFF=1 in the header should no longer read past the end of the buffer.

Diff Detail

Repository
R321 KStars
Branch
debayer-offset (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23396
Build 23414: arc lint + arc unit
murveit created this revision.Mar 7 2020, 1:53 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 7 2020, 1:53 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
murveit requested review of this revision.Mar 7 2020, 1:53 AM
mutlaqja accepted this revision.Mar 7 2020, 5:28 AM
This revision is now accepted and ready to land.Mar 7 2020, 5:28 AM
Closed by commit R321:8c53c246b7cd: Fix a bug in the debayer offset code. (authored by murveit, committed by mutlaqja). · Explain WhyMar 7 2020, 5:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkstars/fitsviewer/fitsdata.cpp (41 lines)

Diff 77149

View Options

kstars/fitsviewer/fitsdata.cpp

Loading...