Differential D27851

Add rss icons in action
ClosedPublic
Actions

Authored by ognarb on Mar 4 2020, 11:23 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Breeze
Commits
R266:861f6ab52dc3: Add rss icons in action
Test Plan

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Mar 4 2020, 11:23 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 4 2020, 11:23 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ognarb requested review of this revision.Mar 4 2020, 11:23 PM
ognarb edited the test plan for this revision. (Show Details)Mar 4 2020, 11:25 PM
ognarb added a reviewer: ndavis.
ognarb added a project: Breeze.
cblack edited reviewers, added: VDG, Breeze; removed: ndavis.Mar 4 2020, 11:30 PM
cblack added a subscriber: cblack.Mar 4 2020, 11:33 PM

SVG-wise, optimization here seems suboptimal. There's excess elements that could be removed.

Visually, the icon looks like the RSS icon, which is about all you need out of an RSS icon.

I do believe we need at least 16px and 22px for monochromatic actions, though.

ndavis accepted this revision.Mar 4 2020, 11:53 PM
ndavis added a subscriber: ndavis.
In D27851#622296, @cblack wrote:

SVG-wise, optimization here seems suboptimal. There's excess elements that could be removed.

Visually, the icon looks like the RSS icon, which is about all you need out of an RSS icon.

I do believe we need at least 16px and 22px for monochromatic actions, though.

The main reason we optimize is to make the code readable, not to make it as small as possible. The current version is fine.

This revision is now accepted and ready to land.Mar 4 2020, 11:53 PM
Closed by commit R266:861f6ab52dc3: Add rss icons in action (authored by ognarb). · Explain WhyMar 5 2020, 12:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMicons-dark/actions/22/rss.svg (10 lines)
AMicons/actions/22/rss.svg (10 lines)

Diff 76979

View Options

icons-dark/actions/22/rss.svg

Loading...
View Options

icons/actions/22/rss.svg

Loading...