Differential D27799

Use system color scheme from Kirigami instead of Plasma theme color
ClosedPublic
Actions

Authored by jgrulich on Mar 3 2020, 9:22 AM.

Details

Reviewers
ngraham
davidedmundson
Group Reviewers
Plasma
Commits
R116:c9b2684a49d3: Use system color scheme from Kirigami instead of Plasma theme color
Summary

BUG: 418416

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
bug-418416
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23174
Build 23192: arc lint + arc unit
jgrulich created this revision.Mar 3 2020, 9:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 3 2020, 9:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich requested review of this revision.Mar 3 2020, 9:22 AM
jgrulich added a reviewer: Plasma.Mar 3 2020, 9:22 AM

One thing I'm not sure about whether to use viewBackgroundColor or just backgroundColor, because I want the buttons to look like they are part of the view.

davidre added a subscriber: davidre.Mar 3 2020, 9:59 AM
davidre added inline comments.
kcm/qml/main.qml
43 ↗(On Diff #76824)

viewBackgroundColor is deprecated
WARNING: viewBackgroundColor is deprecated, use backgroundColor with colorSet: Theme.View instead

jgrulich updated this revision to Diff 76830.Mar 3 2020, 10:19 AM

Don't use deprecated color

davidedmundson accepted this revision.Mar 3 2020, 12:11 PM
This revision is now accepted and ready to land.Mar 3 2020, 12:11 PM
Closed by commit R116:c9b2684a49d3: Use system color scheme from Kirigami instead of Plasma theme color (authored by jgrulich). · Explain WhyMar 3 2020, 12:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (15 lines)
Mkcm/qml/main.qml (5 lines)

Diff 76830

View Options

CMakeLists.txt

Loading...
View Options

kcm/qml/main.qml

Loading...