Differential D27795

Expose capture signal on KeySequenceItem
ClosedPublic
Actions

Authored by iasensio on Mar 2 2020, 9:45 PM.

Details

Reviewers
mart
davidedmundson
Group Reviewers
Plasma
Commits
R296:1a838e468d05: Expose capture signal on KeySequenceItem
Summary

Expose the signal captureFinished from the private helper to KeySequenceItem.
Currently, if we set keySequence from a model and use onKeySequenceChanged to
update that model, a binding loop happens. Using onCaptureFinished prevents that.

Test Plan
keySequence: modelData
onCaptureFinished: { modelData = keySequence }

Diff Detail

Repository
R296 KDeclarative
Branch
expose_capture
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23163
Build 23181: arc lint + arc unit
iasensio created this revision.Mar 2 2020, 9:45 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 2 2020, 9:45 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
iasensio requested review of this revision.Mar 2 2020, 9:45 PM
davidedmundson accepted this revision.Mar 2 2020, 9:56 PM
This revision is now accepted and ready to land.Mar 2 2020, 9:56 PM
davidedmundson added inline comments.Mar 2 2020, 9:57 PM
src/qmlcontrols/kquickcontrols/KeySequenceItem.qml
13 ↗(On Diff #76807)

If you could add API docs that'd be really great

iasensio updated this revision to Diff 76808.Mar 2 2020, 10:09 PM
iasensio marked an inline comment as done.

Add API comment

Closed by commit R296:1a838e468d05: Expose capture signal on KeySequenceItem (authored by iasensio). · Explain WhyMar 2 2020, 10:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76808

View Options

src/qmlcontrols/kquickcontrols/KeySequenceItem.qml

Loading...