Remove 48px telegram icons
ClosedPublic

Authored by ndavis on Mar 2 2020, 4:09 PM.

Details

Reviewers
None
Group Reviewers
VDG
Commits
R266:8fb85eb7cca0: Remove 48px telegram icons
Summary

The style doesn't preserve the original branding very well and the official telegram icon is close enough to being a Breeze icon that we don't need a replacement icon.

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Mar 2 2020, 4:09 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 2 2020, 4:09 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Mar 2 2020, 4:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2020, 7:19 PM
This revision was automatically updated to reflect the committed changes.
rocka added a subscriber: rocka.Mar 3 2020, 8:22 AM

Could we please not remove this icon, or at least keep it available as an alternative? It fits the general style so well.

ndavis added a comment.EditedMar 3 2020, 1:34 PM

Could we please not remove this icon, or at least keep it available as an alternative? It fits the general style so well.

The only way to have an alternative icon is to make an alternative icon theme that uses the alternative icon as its only icon.

This is close enough to being a breeze icon that we really don't need our own version of it for now: https://raw.githubusercontent.com/telegramdesktop/tdesktop/dev/Telegram/Resources/art/icon512.png

If the desktop client icon changes to an incompatible style, we'll make a new breeze telegram icon.

ngraham added a subscriber: ngraham.Mar 4 2020, 4:06 PM

Here's one problem from simply removing the existing Breeze theme SVG icons: the icons shipped in Telegram are raster .pngs which can scale poorly, and the circular effect seems quite badly done for the 48px version in particular. For example here's how Telegram's icon now looks in my 60px thickness panel with an IOTM:

This is Telegram's fault, of course. But it's still gonna bite our users until they fix it.