Auxiliary tests (skeletons).
ClosedPublic

Authored by TallFurryMan on Feb 29 2020, 1:14 PM.

Details

Summary

A few skeleton test classes for the auxiliary elements (all tests skipped for now).
Tests "testcsvparser", "testfwparser", "testdms" and "testcachingdms" are all consolidated into one single executable, "auxiliary_tests".

Test Plan

Execute auxiliary_tests, either from the command line or from the QtCreator project run or from the QtCreator test run, no test fails.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
TallFurryMan created this revision.Feb 29 2020, 1:14 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFeb 29 2020, 1:14 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
TallFurryMan requested review of this revision.Feb 29 2020, 1:14 PM
TallFurryMan planned changes to this revision.Feb 29 2020, 1:15 PM

This bases on D27678, so the diff may be quite unreadable for now. I'll rebase when D27678 is merged.

  • Fix missing copyright.

Next I'll be looking into adding those tests to the build.

Looking at the current Extragear build for SuSE, I see that:

10:45:26  Test project /home/jenkins/workspace/Extragear/kstars/stable-kf5-qt5 SUSEQt5.12/build
10:45:26      Start 1: appstreamtest
10:45:26  kf5.kinit.klauncher: new app ":1.1"
10:45:26  kf5.kinit.klauncher: new app ":1.2"
10:45:26  kf5.kinit.klauncher: new app "org.gtk.vfs.Daemon"
10:45:27  1/6 Test #1: appstreamtest ....................   Passed    0.87 sec
10:45:27      Start 2: CSVParserTest
10:45:27  2/6 Test #2: CSVParserTest ....................   Passed    0.23 sec
10:45:27      Start 3: FixedWidthParserTest
10:45:27  3/6 Test #3: FixedWidthParserTest .............   Passed    0.22 sec
10:45:27      Start 4: DMSTest
10:45:27  4/6 Test #4: DMSTest ..........................   Passed    0.16 sec
10:45:27      Start 5: TestCachingDms
10:45:28  5/6 Test #5: TestCachingDms ...................   Passed    0.20 sec
10:45:28      Start 6: TestSkyPoint
10:45:28  6/6 Test #6: TestSkyPoint .....................   Passed    0.20 sec

Which means the test plan "appstreamtest" is using the test executables in "auxiliary". This differential merges those executables into a single one. Was this a good idea? I can revert to multiple executables, but the CMakefile will grow larger and larger. Opinion?

  • Revert to multiple test executables, fix copyrights.
TallFurryMan planned changes to this revision.Mar 2 2020, 8:22 PM

So, compatible with Extragear build as of now. As far as I understand, additional (empty) tests will be added to the test step automatically...?

TallFurryMan requested review of this revision.Mar 2 2020, 8:23 PM
mutlaqja accepted this revision.Mar 2 2020, 8:35 PM

This looks good to me! We're finally getting some proper testings in place.

This revision is now accepted and ready to land.Mar 2 2020, 8:35 PM
This revision was automatically updated to reflect the committed changes.