Cleanup accounts kded module
ClosedPublic
Actions

Authored by nicolasfella on Feb 27 2020, 5:12 PM.

Details

Reviewers

bshah
leinir

Group Reviewers

Frameworks

Commits

R155:4d36ced449f2: Cleanup accounts kded module

Summary

Rename to emphasize it's a kded module plus some random cleanup

Test Plan

builds, kded5 starts

Diff Detail

Repository

R155 KAccounts Integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella requested review of this revision.Feb 27 2020, 5:12 PM

nicolasfella created this revision.

Harbormaster completed remote builds in B23032: Diff 76570.Feb 27 2020, 5:12 PM

rebase

Harbormaster completed remote builds in B23408: Diff 77182.Mar 7 2020, 8:14 PM

With the caveat that i'm not a big pile of brains about the plugin system, this looks like pretty sensible to me :)

This revision is now accepted and ready to land.Mar 9 2020, 9:46 AM

bshah accepted this revision.Mar 9 2020, 10:41 AM

Closed by commit R155:4d36ced449f2: Cleanup accounts kded module (authored by nicolasfella). · Explain WhyMar 9 2020, 2:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/CMakeLists.txt (2 lines)
V			src/{daemon → kded}/CMakeLists.txt
V			src/{daemon/daemon.h → kded/kded_accounts.h}
V			src/{daemon/daemon.cpp → kded/kded_accounts.cpp}
V			src/{daemon → kded}/kded_accounts.json
V			src/{daemon → kded}/kio-webdav/CMakeLists.txt
V			src/{daemon → kded}/kio-webdav/createkioservice.h
V			src/{daemon → kded}/kio-webdav/createkioservice.cpp
V			src/{daemon → kded}/kio-webdav/createnetattachjob.h
V			src/{daemon → kded}/kio-webdav/createnetattachjob.cpp
V			src/{daemon → kded}/kio-webdav/kioservices.h
V			src/{daemon → kded}/kio-webdav/kioservices.cpp
V			src/{daemon → kded}/kio-webdav/removekioservice.h
V			src/{daemon → kded}/kio-webdav/removekioservice.cpp
V			src/{daemon → kded}/kio-webdav/removenetattachjob.h
V			src/{daemon → kded}/kio-webdav/removenetattachjob.cpp
V			src/{daemon → kded}/kio-webdav/tests/CMakeLists.txt
V			src/{daemon → kded}/kio-webdav/tests/testnetattachjobs.cpp
V			src/{kded ← daemon}/CMakeLists.txt (2 lines)
V			src/{kded/kded_accounts.h ← daemon/daemon.h} (16 lines)
V			src/{kded/kded_accounts.cpp ← daemon/daemon.cpp} (26 lines)
V			src/{kded ← daemon}/kded_accounts.json
V			src/{kded ← daemon}/kio-webdav/CMakeLists.txt
V			src/{kded ← daemon}/kio-webdav/createkioservice.h
V			src/{kded ← daemon}/kio-webdav/createkioservice.cpp
V			src/{kded ← daemon}/kio-webdav/createnetattachjob.h
V			src/{kded ← daemon}/kio-webdav/createnetattachjob.cpp
V			src/{kded ← daemon}/kio-webdav/kioservices.h
V			src/{kded ← daemon}/kio-webdav/kioservices.cpp
V			src/{kded ← daemon}/kio-webdav/removekioservice.h
V			src/{kded ← daemon}/kio-webdav/removekioservice.cpp
V			src/{kded ← daemon}/kio-webdav/removenetattachjob.h
V			src/{kded ← daemon}/kio-webdav/removenetattachjob.cpp
V			src/{kded ← daemon}/kio-webdav/tests/CMakeLists.txt
V			src/{kded ← daemon}/kio-webdav/tests/testnetattachjobs.cpp

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	76570	730e5c7		Feb 27 2020, 5:12 PM	★	★
Diff 2	77182	9cc619d	rebase	Mar 7 2020, 8:14 PM	★	★
Diff 3	77277	ebbb64a	R155:4d36ced449f2789fbb2728d5b2c05b31f4b0876a	Mar 9 2020, 2:06 PM	★	★