Differential D27698

Fix PrivateActionToolButton behaviour with showText vs IconOnly
ClosedPublic
Actions

Authored by ahiemstra on Feb 27 2020, 12:51 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:6f27f90cfa1e: Fix PrivateActionToolButton behaviour with showText vs IconOnly
Summary

PrivateActionToolButton behaves slightly different when setting
showText to false versus setting display to IconOnly. This is
because the implicitWidth binding does not check the display
property. This fixes that to make sure both showText: false
and display: IconOnly return the implicitHeight, making the
button square in both cases.

Test Plan

Kirigami Gallery still works correctly.

Diff Detail

Repository
R169 Kirigami
Branch
patb_icononly_width
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23011
Build 23029: arc lint + arc unit
ahiemstra created this revision.Feb 27 2020, 12:51 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 27 2020, 12:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Feb 27 2020, 12:51 PM
mart accepted this revision.Mar 2 2020, 11:31 AM
This revision is now accepted and ready to land.Mar 2 2020, 11:31 AM
Closed by commit R169:6f27f90cfa1e: Fix PrivateActionToolButton behaviour with showText vs IconOnly (authored by ahiemstra). · Explain WhyMar 3 2020, 9:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76537

View Options

src/controls/private/PrivateActionToolButton.qml

Loading...