Fix PrivateActionToolButton behaviour with showText vs IconOnly

Authored by ahiemstra on Feb 27 2020, 12:45 PM.

Description

Fix PrivateActionToolButton behaviour with showText vs IconOnly

Summary:
PrivateActionToolButton behaves slightly different when setting
showText to false versus setting display to IconOnly. This is
because the implicitWidth binding does not check the display
property. This fixes that to make sure both showText: false
and display: IconOnly return the implicitHeight, making the
button square in both cases.

Test Plan: Kirigami Gallery still works correctly.

Reviewers: Kirigami, mart

Reviewed By: Kirigami, mart

Subscribers: plasma-devel

Tags: Kirigami

Differential Revision: https://phabricator.kde.org/D27698

Details

Committed
ahiemstraMar 3 2020, 9:18 AM
Reviewer
Kirigami
Differential Revision
D27698: Fix PrivateActionToolButton behaviour with showText vs IconOnly
Parents
R169:fd0f3ea202f3: Add an autotest for ActionToolBar
Branches
Unknown
Tags
Unknown