Differential D2766

More config descriptions
ClosedPublic
Actions

Authored by davidedmundson on Sep 14 2016, 12:22 AM.

Details

Reviewers
mart
hein
Group Reviewers
Plasma
Commits
R120:ec8b02a7c417: More config descriptions
R871:ec8b02a7c417: More config descriptions

Diff Detail

Repository
R120 Plasma Workspace
Branch
arcpatch-D2766
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson updated this revision to Diff 6710.Sep 14 2016, 12:22 AM
davidedmundson retitled this revision from to More config descriptions.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 14 2016, 12:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein requested changes to this revision.Sep 14 2016, 7:13 AM
hein added a reviewer: hein.
hein added a subscriber: hein.
hein added inline comments.
applets/digital-clock/package/contents/config/main.xml
10

I know this is increeeedibly nitpicky, but ... I ended the labels in the other applets with periods, could we make this consistent? :)

26

What's a valid font string?

30

s/fault/font

44–45

Could be nicer, something like "When multiple time zones are configured, this is the one shown on widget restore."

49

*switches between the time zones configured in selectedTimeZones.

57

*Whether

applets/systemmonitor/common/contents/config/main.xml
10 ↗(On Diff #6710)

*comma-separated

This revision now requires changes to proceed.Sep 14 2016, 7:13 AM
davidedmundson updated this revision to Diff 6733.Sep 14 2016, 12:47 PM
davidedmundson edited edge metadata.
davidedmundson marked 6 inline comments as done.

Updated

mart accepted this revision.Sep 15 2016, 9:03 AM
mart added a reviewer: mart.
mart added a subscriber: mart.

good, still a couple of nitpicks

applets/digital-clock/package/contents/config/main.xml
34

"Sets the clock font to italic."

53

i.e.

applets/lock_logout/contents/config/main.xml
10

"Shows an option" would sound better? (tough i don't english enough, i may be very wrong :)

Closed by commit R120:ec8b02a7c417: More config descriptions (authored by davidedmundson). · Explain WhySep 15 2016, 11:01 AM
This revision was automatically updated to reflect the committed changes.
davidedmundson marked an inline comment as done.

Revision Contents
Changeset List

Diff 6733

View Options

applets/digital-clock/package/contents/config/main.xml

Loading...
View Options

applets/lock_logout/contents/config/main.xml

Loading...