Differential D27658

Remove the "Candy" category and fold its contents into "Appearance"
ClosedPublic
Actions

Authored by ngraham on Feb 25 2020, 5:09 PM.

Details

Reviewers
zzag
abetts
Group Reviewers
KWin
VDG
Commits
R108:04aff77f9426: Remove the "Candy" category and fold its contents into "Appearance"
Summary

The "Candy" category suffers from some problems:

  • It does not need to exist; everything in it is purely appearance-related and could live in the existing "Appearance" category
  • The name is inappropriate; "Eye Candy" would be better, but changing it to this has proven controversial in the past

Let's just remove the category and move everything in it into the "Appearance" category.

Test Plan

Apply and compile
Open Desktop Effects KCM
See that the "Candy" category is no more and the "Appearance" category has more stuff in it

Diff Detail

Repository
R108 KWin
Branch
no-more-candy (branched from master)
Lint
Lint SkippedExcuse: I hate lint, it's gross
Unit
No Unit Test Coverage
Build Status
Buildable 22921
Build 22939: arc lint + arc unit
ngraham created this revision.Feb 25 2020, 5:09 PM
Restricted Application added projects: KWin, Documentation. · View Herald TranscriptFeb 25 2020, 5:09 PM
Restricted Application added subscribers: kde-doc-english, kwin. · View Herald Transcript
ngraham requested review of this revision.Feb 25 2020, 5:09 PM
zzag accepted this revision.Feb 25 2020, 6:14 PM
zzag added a subscriber: zzag.

This change may break third party effects. On the other hand, I haven't encountered any "eye candy" effects in the wild besides ours.

This revision is now accepted and ready to land.Feb 25 2020, 6:14 PM
abetts accepted this revision.Feb 25 2020, 6:25 PM
Closed by commit R108:04aff77f9426: Remove the "Candy" category and fold its contents into "Appearance" (authored by ngraham). · Explain WhyFeb 25 2020, 6:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76395

View Options

doc/kwineffects/index.docbook

Loading...
View Options

effects/effect_builtins.cpp

Loading...
View Options

kcmkwin/common/effectsmodel.cpp

Loading...