throw out the windows variant of the smb slave
ClosedPublic

Authored by sitter on Feb 25 2020, 1:02 PM.

Details

Summary

it hasn't been built in ages because the top level cmakelists actually only
adds the smb dir when samba is found (which would be never I guess?).
it is also continuously ignored when sweeping changes are made (such as
the move to json plugin metadata or the debug category change).

overall it is entirely useless as native UNC path handling seems to work
just fine these days in for example okular and kate. so, I very much
believe that bespoke smb handling is entirely moot on windows (as it
should be, really)

Test Plan

okular and kate still open remote UNC paths without it on windows

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Feb 25 2020, 1:02 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptFeb 25 2020, 1:02 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Feb 25 2020, 1:02 PM
vonreth accepted this revision.Feb 25 2020, 3:14 PM
This revision is now accepted and ready to land.Feb 25 2020, 3:14 PM
ngraham accepted this revision.Feb 25 2020, 4:05 PM
This revision was automatically updated to reflect the committed changes.