Differential D27644

do not hide enum warnings via switch default label
ClosedPublic
Actions

Authored by sitter on Feb 25 2020, 10:30 AM.

Details

Reviewers
ngraham
Commits
R320:d0e16b8326d4: smb: do not hide enum warnings via switch default label
Summary

should we ever extend the url types the compiler will not warn us that
the new type may need handling. instead return when we have handled
a type so the fallback can be moved after the switch

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Feb 25 2020, 10:30 AM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptFeb 25 2020, 10:30 AM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Feb 25 2020, 10:30 AM
ngraham accepted this revision.Feb 25 2020, 3:58 PM
This revision is now accepted and ready to land.Feb 25 2020, 3:58 PM
Closed by commit R320:d0e16b8326d4: smb: do not hide enum warnings via switch default label (authored by sitter). · Explain WhyFeb 26 2020, 11:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmb/kio_smb_browse.cpp (15 lines)

Diff 76449

View Options

smb/kio_smb_browse.cpp

Loading...