kill twitter support
ClosedPublic
Actions

Authored by nicolasfella on Feb 24 2020, 11:35 PM.

Details

Reviewers

apol
bshah

Group Reviewers

Frameworks

Commits

R495:13f9f45f2cce: kill twitter support

Summary

Twitter support in KAccounts has been reportedly broken for years (https://bugs.kde.org/show_bug.cgi?id=363260) and is currently disabled. Therefor the twitter plugin cannot work. We have no complaint about it not working in Purpose bugs, which makes me conclude it won't be missed.

It allows us to get rid of the ugly dependency on nodejs, too.

Diff Detail

Repository

R495 Purpose Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.Feb 24 2020, 11:35 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 24 2020, 11:35 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

nicolasfella requested review of this revision.Feb 24 2020, 11:35 PM

Harbormaster completed remote builds in B22883: Diff 76334.Feb 24 2020, 11:35 PM

bshah accepted this revision.Feb 25 2020, 5:18 AM

This revision is now accepted and ready to land.Feb 25 2020, 5:18 AM

apol accepted this revision.Feb 25 2020, 5:45 PM

Closed by commit R495:13f9f45f2cce: kill twitter support (authored by nicolasfella). · Explain WhyFeb 25 2020, 5:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (8 lines)
M		src/plugins/CMakeLists.txt (5 lines)
D	M	src/plugins/twitter-microblog.service.in (10 lines)
D	M	src/plugins/twitter/Messages.sh (3 lines)
D	M	src/plugins/twitter/contents/code/main.js.in (136 lines)
D	M	src/plugins/twitter/contents/code/package.json (12 lines)
D	M	src/plugins/twitter/contents/config/config.qml (78 lines)
D	M	src/plugins/twitter/metadata.json (158 lines)