Details
Details
- Reviewers
bshah leinir - Group Reviewers
Frameworks - Commits
- R155:693d7361428e: Restore kio-webdav plugin
Diff Detail
Diff Detail
- Repository
- R155 KAccounts Integration
- Branch
- restore
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22931 Build 22949: arc lint + arc unit
Comment Actions
Minus that little API funniness, looks pretty good from here :)
| src/daemon/kio-webdav/CMakeLists.txt | ||
|---|---|---|
| 9–14 ↗ | (On Diff #76328) | wouldn't mention it, but as there's other stuff as well, looks like a stray newline :) |
| src/lib/kaccountsdplugin.h | ||
| 57 ↗ | (On Diff #76416) | This still introduces a API break, though... Which seems especially silly given the arguments aren't actually used. Perhaps add a new ctor, and have the one without the arguments call the new one, but also make a qwarning (or something similar) note that it's using an old ctor and really out to upgrade? |
| src/lib/kaccountsdplugin.h | ||
|---|---|---|
| 57 ↗ | (On Diff #76416) | This shouldn't be in this diff at all |