Differential D27620

[krun] Share implementation of runService and runApplication
ClosedPublic
Actions

Authored by davidedmundson on Feb 24 2020, 10:17 AM.

Details

Reviewers
apol
Commits
R241:a35cbeabc162: [krun] Share implementation of runService and runApplication
Summary

Since they now effectively do the same thing.
This patch also saves recent documents when runApplication is called

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 24 2020, 10:17 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 24 2020, 10:17 AM
apol accepted this revision.Feb 24 2020, 4:07 PM
apol added a subscriber: apol.
apol added inline comments.
src/widgets/krun.cpp
716

while at it, let's stop calling it kicker?

This revision is now accepted and ready to land.Feb 24 2020, 4:07 PM
apol added a comment.Feb 24 2020, 4:11 PM

Don't we need KDesktopFile::isAuthorizedDesktopFile now?

Closed by commit R241:a35cbeabc162: [krun] Share implementation of runService and runApplication (authored by davidedmundson). · Explain WhyMar 2 2020, 10:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/krun.cpp (27 lines)

Diff 76756

View Options

src/widgets/krun.cpp

Loading...