Differential D27475

Make kwapper/kshell spawn klauncher5 if needed
ClosedPublic
Actions

Authored by davidedmundson on Feb 18 2020, 2:00 PM.

Details

Reviewers
apol
Commits
R303:f3264622f96d: Make kwrapper/kshell spawn klauncher5 if needed
Summary

In an attempt to phase kinit out plasma will at some point stop spawning klauncher5

This means we need the cli-tools to spawn it themselves if activated for
full compatibility

Test Plan

didn't spawn kdeinit5
ran kwrapper5 ls

Diff Detail

Repository
R303 KInit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22636
Build 22654: arc lint + arc unit
davidedmundson created this revision.Feb 18 2020, 2:00 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 18 2020, 2:00 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Feb 18 2020, 2:00 PM
davidedmundson added a comment.Feb 18 2020, 2:05 PM

Requires D27476 to not crash

apol added a subscriber: apol.Feb 18 2020, 3:13 PM
apol added inline comments.
CMakeLists.txt
57

I suppose this should be if (NOT WIN32)?

I'm not entirely sure why it's just added to some.

apol accepted this revision.Feb 18 2020, 5:48 PM
This revision is now accepted and ready to land.Feb 18 2020, 5:48 PM
Closed by commit R303:f3264622f96d: Make kwrapper/kshell spawn klauncher5 if needed (authored by davidedmundson). · Explain WhyMar 2 2020, 10:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75924

View Options

CMakeLists.txt

Loading...
View Options

src/kdeinit/CMakeLists.txt

Loading...
View Options

src/kshell/CMakeLists.txt

Loading...
View Options

src/kwrapper/CMakeLists.txt

Loading...
View Options

src/wrapper.cpp

Loading...