fix activity runner
Needs ReviewPublic

Authored by McPain on Thu, Feb 13, 1:42 PM.

Details

Summary

Activity runner is now useless:

m_activities is always nullptr in ActivityRunner::run because ActivityRunner::down is called after ActivityRunner::match which makes activity changing impossible

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
McPain created this revision.Thu, Feb 13, 1:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Feb 13, 1:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
McPain requested review of this revision.Thu, Feb 13, 1:42 PM

Urgh. I suspect this was a hidden bug from when runnermanager never emitted teardown.

Given how runnermanager currently seems to work, this patch does make sense.

runners/activities/activityrunner.cpp
79

you don't need this new code, m_activites has this as a parent, we can just delete the code in down()