Differential D27367

fix activity runner
ClosedPublic
Actions

Authored by McPain on Feb 13 2020, 1:42 PM.

Details

Reviewers
broulik
ngraham
davidedmundson
Commits
R120:2a979a4bbebe: fix activity runner
Summary

Activity runner is now useless:

m_activities is always nullptr in ActivityRunner::run because ActivityRunner::down is called after ActivityRunner::match which makes activity changing impossible

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
McPain created this revision.Feb 13 2020, 1:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 13 2020, 1:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
McPain requested review of this revision.Feb 13 2020, 1:42 PM
davidedmundson added a comment.Feb 13 2020, 2:16 PM

Urgh. I suspect this was a hidden bug from when runnermanager never emitted teardown.

Given how runnermanager currently seems to work, this patch does make sense.

runners/activities/activityrunner.cpp
79

you don't need this new code, m_activites has this as a parent, we can just delete the code in down()

McPain updated this revision to Diff 75900.Feb 18 2020, 10:02 AM
McPain marked an inline comment as done.

removed 2nd hunk

davidedmundson accepted this revision.Feb 18 2020, 12:05 PM
This revision is now accepted and ready to land.Feb 18 2020, 12:05 PM
ngraham accepted this revision.Feb 18 2020, 4:17 PM
Closed by commit R120:2a979a4bbebe: fix activity runner (authored by McPain, committed by ngraham). · Explain WhyFeb 18 2020, 4:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75928

View Options

runners/activities/activityrunner.cpp

Loading...