message: Never turn an Image into NormalText

Authored by kfunk on Feb 12 2020, 8:43 AM.



This fixes the Gify posts from our channel bot

Diff Detail

R865 Ruqola
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
kfunk requested review of this revision.Feb 12 2020, 8:43 AM
kfunk created this revision.
kfunk updated this revision to Diff 75518.Feb 12 2020, 8:50 AM

Fix tests

Note: This seems to fix the Gify previews in both ruqola + ruqolaqml.

Not sure the check was there before?

mlaurent requested changes to this revision.Feb 12 2020, 10:07 AM

I added this check when I found a bug about no image preview in message.
Too bad I didn't add testcase for it...

Better to comment line that removing them so we can revert it/improve patch when we will have the bug again.

This revision now requires changes to proceed.Feb 12 2020, 10:07 AM

you can add autotest about it in

> create a json file + ref

add it in "void MessageTest::shouldParseJsonMessage_data()"

So we will be sure that we will not break it in the future.

This revision was not accepted when it landed; it landed in state Needs Revision.Feb 12 2020, 11:43 AM
This revision was automatically updated to reflect the committed changes.