message: Never turn an Image into NormalText
ClosedPublic

Authored by kfunk on Feb 12 2020, 8:43 AM.

Details

Summary

This fixes the Gify posts from our channel bot

Diff Detail

Repository
R865 Ruqola
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22389
Build 22407: arc lint + arc unit
kfunk requested review of this revision.Feb 12 2020, 8:43 AM
kfunk created this revision.
kfunk updated this revision to Diff 75518.Feb 12 2020, 8:50 AM

Fix tests

Note: This seems to fix the Gify previews in both ruqola + ruqolaqml.

Not sure the check was there before?

mlaurent requested changes to this revision.Feb 12 2020, 10:07 AM

I added this check when I found a bug about no image preview in message.
Too bad I didn't add testcase for it...

Better to comment line that removing them so we can revert it/improve patch when we will have the bug again.

This revision now requires changes to proceed.Feb 12 2020, 10:07 AM

you can add autotest about it in
"ruqola/src/core/autotests/data/messages"

> create a json file + ref

add it in "void MessageTest::shouldParseJsonMessage_data()"

So we will be sure that we will not break it in the future.

This revision was not accepted when it landed; it landed in state Needs Revision.Feb 12 2020, 11:43 AM
This revision was automatically updated to reflect the committed changes.